Repository navigation
Add CI that validates the devcontainer environment - #3
Open
jacobcow21 wants to merge 1 commit into
Open
jacobcow21 wants to merge 1 commit into
jacobcow21 wants to merge 1 commit into
Conversation
Build .devcontainer/Dockerfile and check its tools, and build the devcontainer from devcontainer.json so post_install runs, then verify the pre-commit hook and Oh My Zsh plugins it sets up. The Dockerfile no longer copies requirements.txt, which the repo dropped for pyproject.toml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K2qoKiPwvRQs4vZk9EAp7p
Owner
Author
|
Both new devcontainer jobs passed: Generated by Claude Code |
12 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Jacob · project thread
Fixes #4
Describe your change
Adds CI that validates the devcontainer environment.
.devcontainer/Dockerfile: a newdockerfilejob builds the image and checks thatpython3,pre-commit,ruffanduvrun inside it. The Dockerfile could not build before, because it copied arequirements.txtthat the repo no longer has (dependencies live inpyproject.toml/uv.lock). It now uses the same base image asdevcontainer.jsonand installs the same tools.devcontainerjob builds the container fromdevcontainer.jsonwithdevcontainers/ci, which runspostCreateCommand(and so.devcontainer/post_install). It then verifies that the pre-commit hook is installed, both Oh My Zsh plugins were cloned, and~/.zshrcenables them.workflow_dispatch, read-onlypermissions, and limitspushruns tomaster.I tested both jobs' steps locally in Docker, and they passed.
Checklist
https://claude.ai/code/session_01K2qoKiPwvRQs4vZk9EAp7p
Generated by Claude Code